Refactor import paths in LexicalEditorState #6178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz and
ivailop7
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
potatowagon
requested changes
May 28, 2024
Comment on lines
12
to
20
| import type {SerializedElementNode} from './nodes/LexicalElementNode'; | ||
| import type {SerializedRootNode} from './nodes/LexicalRootNode'; | ||
|
|
||
| import invariant from 'shared/invariant'; | ||
|
|
||
| import {$isElementNode, SerializedElementNode} from '.'; | ||
|
|
||
| import {readEditorState} from './LexicalUpdates'; | ||
| import {$getRoot} from './LexicalUtils'; | ||
| import {$isElementNode} from './nodes/LexicalElementNode'; |
There was a problem hiding this comment.
these should auto sort upon saving if not try
./node_modules/.bin/eslint ./ --fix
| import type {SerializedRootNode} from './nodes/LexicalRootNode'; | ||
|
|
||
| import invariant from 'shared/invariant'; | ||
|
|
||
| import {$isElementNode, SerializedElementNode} from '.'; | ||
|
|
There was a problem hiding this comment.
nit: pls remove the extra line (tho auto fix should solve that)
There was a problem hiding this comment.
Thanks for the help!
The empty line is removed after saving, and the sorting was also done.
This sort outcome is the outcome from ESLint.
|
Thanks :) |
This was referenced Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[lexical] Refactor: Change import paths syntax in LexicalEditorState
Description
The current behavior implements not consistent import approaches which can lead to confusion.
This pull request addresses the issue by using consistent import syntax to make it easier to understand
which module is from where imported.